fix double login URL with OIDC #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
4 tasks
juanfont
approved these changes
Feb 25, 2025
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
kradalby
force-pushed
the
kradalby/double-redir
branch
from
aa5c16c to
13dd6f0
Compare
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Feb 25, 2025
* factor out login url parser Signed-off-by: Kristoffer Dalby <[email protected]> * move to not trigger test gen checker Signed-off-by: Kristoffer Dalby <[email protected]> * return regresp or err after waiting for registration Signed-off-by: Kristoffer Dalby <[email protected]> * update changelog Signed-off-by: Kristoffer Dalby <[email protected]> --------- Signed-off-by: Kristoffer Dalby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2441
what essentially happens is:
node tries to register, gets URL
node reopens the connection with a "followup url"
registration code sits in the followup and waits for the registration to complete
error goes here: it didnt return when the followup finished, it continued the code and sent a new registration url